rogs/yams
rogs/yams
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

Implement configuration directory customization. #74

Closed
trente.artist wants to merge 7 commits from add-config-dir-selection- into master
pull from: add-config-dir-selection-
merge into: rogs:master
Conversation 14 Commits 7 Files Changed 5 +36 -17
trente.artist commented 2025-03-19 20:23:49 -03:00 (Migrated from gitlab.com)
Copy Link

This adds the ability to select a configuration directory for all the things. These changes allow people who need to use their home directory for configuration and logs to do so, (in case their home folder has more storage than their root directory).

This adds the ability to select a configuration directory for all the things. These changes allow people who **need** to use their home directory for configuration and logs to do so, (in case their home folder has more storage than their root directory).
trente.artist commented 2025-03-19 20:25:55 -03:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>e53c7082 - fix typo</li></ul> [Compare with previous version](/rogs/yams/-/merge_requests/25/diffs?diff_id=1300745999&start_sha=50aabdd401ad5e8c6faac0f81080534d3ac92cc8)
trente.artist commented 2025-03-19 20:32:44 -03:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 6f0eaf6b - add configuration info to readme.org

Compare with previous version

added 1 commit <ul><li>6f0eaf6b - add configuration info to readme.org</li></ul> [Compare with previous version](/rogs/yams/-/merge_requests/25/diffs?diff_id=1300750523&start_sha=e53c7082cc6ceddf2f3a107f37ccce44d7becc50)
trente.artist commented 2025-03-19 20:33:44 -03:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • aebe2e2f - fix line stuff from readme.org

Compare with previous version

added 1 commit <ul><li>aebe2e2f - fix line stuff from readme.org</li></ul> [Compare with previous version](/rogs/yams/-/merge_requests/25/diffs?diff_id=1300751160&start_sha=6f0eaf6b7c6226f6b923a8b4da9ef6af02623f91)
trente.artist commented 2025-03-19 20:41:05 -03:00 (Migrated from gitlab.com)
Copy Link

I THINK I just need to edit the docs before this can be merged. Don't know for sure though.

I THINK I just need to edit the docs before this can be merged. Don't know for sure though.
trente.artist commented 2025-03-19 20:52:59 -03:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • e913c252 - update docs.org with updated source.

Compare with previous version

added 1 commit <ul><li>e913c252 - update docs.org with updated source.</li></ul> [Compare with previous version](/rogs/yams/-/merge_requests/25/diffs?diff_id=1300761764&start_sha=aebe2e2ff259b44e2b2c8bb4533780174a0a1bd9)
trente.artist commented 2025-03-19 20:58:12 -03:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>b3c7a7c0 - fix missing changes</li></ul> [Compare with previous version](/rogs/yams/-/merge_requests/25/diffs?diff_id=1300763887&start_sha=e913c252b0f833b82292e55032b3fb2747c8a785)
trente.artist commented 2025-03-19 21:00:10 -03:00 (Migrated from gitlab.com)
Copy Link

Done with most of the stuff that I think my changes affect. Please let me know what else is needed if anything

Done with most of the stuff that I think my changes affect. Please let me know what else is needed if anything
trente.artist commented 2025-03-19 21:03:51 -03:00 (Migrated from gitlab.com)
Copy Link

changed the description

changed the description
trente.artist (Migrated from gitlab.com) changed target branch from master to add-vpn-documentation-warning 2025-03-19 21:03:51 -03:00
trente.artist commented 2025-03-19 21:05:30 -03:00 (Migrated from gitlab.com)
Copy Link

changed title from {-add C-}onfiguration dir to {+Implement c+}onfiguration dir{+ectory customization.+}

changed title from **{-add C-}onfiguration dir** to **{+Implement c+}onfiguration dir{+ectory customization.+}**
trente.artist (Migrated from gitlab.com) changed target branch from add-vpn-documentation-warning to master 2025-03-19 21:05:30 -03:00
rogs commented 2025-03-19 21:14:28 -03:00 (Migrated from gitlab.com)
Copy Link

Hey!

I don't understand the purpose of this change. 🤔

First of all, you can already install YAMS in your home directory. It's the first question the installer asks.

Second, this change will make debugging much more difficult since all the directories will be spread across multiple locations.

Third, this change will affect the backup command and harm the portability of YAMS.

I'm having a hard time letting this one through, but please let me know if I'm missing something with this change. 👍

Hey! I don't understand the purpose of this change. :thinking: First of all, you can already install YAMS in your home directory. [It's the first question the installer asks](https://yams.media/install/steps/#1-setup-your-install-location). Second, this change will make debugging much more difficult since all the directories will be spread across multiple locations. Third, this change will affect the backup command and harm the portability of YAMS. I'm having a hard time letting this one through, but please let me know if I'm missing something with this change. :thumbsup:
rogs commented 2025-03-19 21:19:00 -03:00 (Migrated from gitlab.com)
Copy Link

Another thing I forgot to mention: your INSTALL_DIRECTORY shouldn't get too big. Mine is 16GB, with 12GB of that being Emby cache, something I could clean up but haven't because I'm lazy.

I've been running YAMS for over three years and currently have 21TB of TV shows and 6TB of movies.

image{width=323 height=210}

Another thing I forgot to mention: your `INSTALL_DIRECTORY` shouldn't get too big. Mine is 16GB, with 12GB of that being Emby cache, something I could clean up but haven't because I'm lazy. I've been running YAMS for over three years and currently have 21TB of TV shows and 6TB of movies. ![image](/uploads/987d480553c713c4e5b88c6ff3bef9f8/image.png){width=323 height=210}
trente.artist commented 2025-03-19 21:23:54 -03:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • d9409542 - fix .env.example to implement CONFIG_DIRECTORY for the install script

Compare with previous version

added 1 commit <ul><li>d9409542 - fix .env.example to implement CONFIG_DIRECTORY for the install script</li></ul> [Compare with previous version](/rogs/yams/-/merge_requests/25/diffs?diff_id=1300781367&start_sha=b3c7a7c0c4b162031f2ee20e8d7dd68d4b6308f2)
trente.artist commented 2025-03-19 21:36:35 -03:00 (Migrated from gitlab.com)
Copy Link

I like keeping things separated. I wanted to put config into .config in the root of the home folder, it's just the way I do stuff. Plus Jellyfin generates a lot of logs and their cache is pretty big. My 70gb root (which does have a bunch of other things in it, not really Yam's fault) was filled up way too quickly. I don't mind keeping my install folder on the root, but moving the config folder to a specific place is just another customization vector for others.

I like keeping things separated. I wanted to put config into .config in the root of the home folder, it's just the way I do stuff. Plus Jellyfin generates a lot of logs and their cache is pretty big. My 70gb root (which does have a bunch of other things in it, not really Yam's fault) was filled up way too quickly. I don't mind keeping my install folder on the root, but moving the config folder to a specific place is just another customization vector for others.
rogs commented 2025-03-19 22:31:31 -03:00 (Migrated from gitlab.com)
Copy Link

Ok, now I understand where you're coming from. YAMS is just a script that sets up a docker-compose file, so I’d recommend using it as is and installing it in your /home partition.

That said, feel free to modify YAMS to suit your needs and distribute your changes independently! Your code looks solid, so YAMS should work just fine. I just don’t think this change is ideal for people who are new to self-hosting, which is YAMS’ main target audience.

Either way, even though it won’t be merged for now, thanks for the MR!

Ok, now I understand where you're coming from. YAMS is just a script that sets up a `docker-compose` file, so I’d recommend using it as is and installing it in your `/home` partition. That said, feel free to modify YAMS to suit your needs and distribute your changes independently! Your code looks solid, so YAMS should work just fine. I just don’t think this change is ideal for people who are new to self-hosting, which is YAMS’ main target audience. Either way, even though it won’t be merged for now, thanks for the MR!
rogs (Migrated from gitlab.com) closed this pull request 2025-03-19 22:31:32 -03:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
add-to-docs
bug
done
feature-request
in progress
troubleshooting
v2
yams extra
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
rogs
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rogs/yams#74
No description provided.
Delete Branch "add-config-dir-selection-"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?