Changed the IP checking service for "check-vpn" #68
Loading…
x
Reference in New Issue
Block a user
No description provided.
Delete Branch "fix-surfshark-check-vpn"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The original "check-vpn" used an endpoint that is no longer online.
FIX: Replace the endpoint with ipinfo.io, a currently active service.
The original fix was for Surfshark, but I'm positive that this will work with any attached VPN.
I can verify
{width=3269 height=57}
curl -s api.ipify.orgstill works on my machine. Your country and/or ISP might be blocking the pagejqis not a requirement for YAMSThis looks hacky. If you can find an API that responds with the raw IP address (like
ifconfig.me), it could be better.Note: Don't use
ifconfig.meas the solution since we used that in the past and had to change it because some users were complaining it was blocked in their countriesWe already changed from
ifconfig.metoapi.ipify.orga few months ago.I'm not against this idea, but if we are going to replace
api.ipify.orgit needs to be with an API that does the same thing. I wouldn't like to introduce more dependencies to YAMS (likejq) without a very good reason.requested changes
no need to use json and grep ->
ipinfo.io/ipapi.ipify.orgworks well for me.but if we're gonna change, one alternative could be
https://am.i.mullvad.net/ipas we use it for the country already.
We had some problems with
https://am.i.mullvad.net/ipin the past. It appears some VPNs block that domain. Thank you for the recomendation onipinfo.io/ip!jqin this context isn't running on the YAMS host but only within the qbittorrent container. In any case usinghttps://ipinfo.io/ipis far more efficient.Turns out my PiHole on my LAN was blocking requests to
ipify.org:P@methbkts Thank you for putting
ipinfo.io/ipon the table.Would it be worth getting a bigger list of endpoints that can be used to get your IP address for others that might be in my situation? It would go down a list of known good endpoints until it finds one that gets a response.
changed this line in version 2 of the diff
changed this line in version 2 of the diff
added 1 commit
Compare with previous version
added 1 commit
3a7dbab3- Changed the IP checking service for "check-vpn"Compare with previous version
I'm kinda hesitant of making this change, but having a list of "possible" endpoints would be nice, and would make the decision a lot easier 😄
added 1 commit
3ff04b84- Added multiple IP checker endpointsCompare with previous version
resolved all threads
I like this change! I don't know why I missed the updates. I'm merging this change 👍
mentioned in commit
b5bf199237things to note, for me the 3 first endpoints gives me ipv4, the 3 others gives me ipv6
Maybe we should regex for a correct IP in the ipv4 format?
Interesting. The important thing is that the region is different but it would be best if you knew that your IP was in fact changed. I can look further into the endpoints I added to see if you can only request an IPv4 address. Note: this will depend on the client side ISP. I’ve heard of some ISP’s only giving their customers IPv6 addresses.
That's super weird because I got ipv4 for all of them...
@MasonStooksbury It’s completely dependent on the routes your ISP uses. @methbkts brings up a good point. It’d be best that you can verify that your public IP is different. Either way, if your VPN is working, your region should be different.
Yep, just saw that. My comment was pending and came out after yours instead lol
@gloof11 maybe you can add a regex check to verify that the IP given is an IPV4? Either way, I think it's overkill. As long as the IPV6 is different than the IPV4 and regions are different, it should be fine