rogs/yams
rogs/yams
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

Figure out what to do with the yams upgrade command #35

New Issue
Closed
opened 2024-09-24 10:15:28 -03:00 by rogs · 9 comments
rogs commented 2024-09-24 10:15:28 -03:00 (Migrated from gitlab.com)
Copy Link

Right now, yams upgrade overwrites configuration changes, and it's more problematic than useful. The purpose of this issue is to discuss what we can possibly do to fix this

Right now, `yams upgrade` overwrites configuration changes, and it's more problematic than useful. The purpose of this issue is to discuss what we can possibly do to fix this
rogs commented 2024-09-24 10:15:29 -03:00 (Migrated from gitlab.com)
Copy Link

assigned to @rogs

assigned to @rogs
rogs commented 2024-09-24 10:15:41 -03:00 (Migrated from gitlab.com)
Copy Link

mentioned in issue yams.media#1

mentioned in issue yams.media#1
rogs commented 2024-09-24 10:16:49 -03:00 (Migrated from gitlab.com)
Copy Link

@MasonStooksbury:

Wouldn't this still be helpful for updates to YAMS itself?
For example, you just merged a change that would modify the check-vpn command. Wouldn't the update command grab that change?

@rogs:

That would make sense... The problem is that the command overwrites the configuration changes, and it created more issues than it fixed.
Maybe we can keep it to ONLY update the yams script and not the docker-compose? That could be a good solution, what do you think?

@MasonStooksbury: > Wouldn't this still be helpful for updates to YAMS itself? > For example, you just merged a change that would modify the check-vpn command. Wouldn't the update command grab that change? @rogs: > That would make sense... The problem is that the command overwrites the configuration changes, and it created more issues than it fixed. > Maybe we can keep it to ONLY update the `yams` script and not the docker-compose? That could be a good solution, what do you think?
MasonStooksbury commented 2024-09-24 10:21:30 -03:00 (Migrated from gitlab.com)
Copy Link

@rogs Moving the discussion over here

Yeah it's tricky. I'm not sure how many people are still on V1 so I would hate to remove it (and all of our documentation on upgrading).

I think the best course might be to add a separate "upgrade.sh" script that does what the current upgrade command does. Then update our documentation to tell people to use that new script

This gets us a few benefits:

  • We don't have one-time commands in the yams binary
  • People still have a way to upgrade from V1 to V2
  • We can modify the update command and description in the binary in a way that is useful
@rogs Moving the discussion over here Yeah it's tricky. I'm not sure how many people are still on V1 so I would hate to remove it (and all of our documentation on upgrading). I think the best course might be to add a separate "upgrade.sh" script that does what the current upgrade command does. Then update our documentation to tell people to use that new script This gets us a few benefits: * We don't have one-time commands in the yams binary * People still have a way to upgrade from V1 to V2 * We can modify the update command and description in the binary in a way that is useful
rogs commented 2024-09-24 10:23:15 -03:00 (Migrated from gitlab.com)
Copy Link

That would make sense. And that's something I can quickly wrap up on the hardlink + rewrite docs PR that I NEED TO WORK ON SOON ™️.

Let's keep this idea around and figure out if there's a better solution, but I definitely don't hate this solution

That would make sense. And that's something I can quickly wrap up on the hardlink + rewrite docs PR that I NEED TO WORK ON SOON :tm:. Let's keep this idea around and figure out if there's a better solution, but I definitely don't hate this solution
MasonStooksbury commented 2024-09-24 10:24:28 -03:00 (Migrated from gitlab.com)
Copy Link

Sounds good. Lemme know if you have any better ideas, would be happy to help. And feel free to hit me up on Discord if there's any planning you'd rather do there than over here lol

Sounds good. Lemme know if you have any better ideas, would be happy to help. And feel free to hit me up on Discord if there's any planning you'd rather do there than over here lol
methbkts commented 2024-09-24 10:28:21 -03:00 (Migrated from gitlab.com)
Copy Link

We don't have one-time commands in the yams binary

Love that

> We don't have one-time commands in the yams binary Love that
rogs commented 2024-12-26 12:10:32 -03:00 (Migrated from gitlab.com)
Copy Link

mentioned in merge request !22

mentioned in merge request !22
rogs commented 2024-12-30 11:01:29 -03:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 76bbdc9537

mentioned in commit 76bbdc95375b1b1092ad39997984e63233902c47
rogs (Migrated from gitlab.com) closed this issue 2024-12-30 11:01:29 -03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
add-to-docs
bug
done
feature-request
in progress
troubleshooting
v2
yams extra
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
rogs
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rogs/yams#35
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?