rogs/yams
rogs/yams
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

wrong capitalisation for <install_DIRECTORY> in yams v2 #33

New Issue
Closed
opened 2024-08-04 14:35:26 -03:00 by geeheich · 1 comment
geeheich commented 2024-08-04 14:35:26 -03:00 (Migrated from gitlab.com)
Copy Link

Hi there, I couldn't find any form of template for issues, so this will be free text.

I just performed the upgrade from v1 to v2 of yams and it worked like a charm, with the exception of one small hickup. When performing the string replacement in the yams script, there appears to be a miscapitalised version of the "<install_DIRECTORY>" string, where "directory" is not capitalised. It's right at the top of the script in line 6.
It did not thoroughly check if this was the only place with the differing capitalisation, but after performing the modified command sed -i -e "s|<install_directory>|/opt/yams|g" yams the updated script worked fine.

as this seems like a good opportunity I wanted to thank you for this very nice project. makes running a homeserver for your digitized media incredibly effortless. the upgrade tutorial is also great! very easy to follow

Hi there, I couldn't find any form of template for issues, so this will be free text. I just performed the upgrade from v1 to v2 of yams and it worked like a charm, with the exception of one small hickup. When performing the string replacement in the _yams_ script, there appears to be a miscapitalised version of the `"<install_DIRECTORY>"` string, where "directory" is not capitalised. It's right at the top of the script in line 6. It did not thoroughly check if this was the only place with the differing capitalisation, but after performing the modified command `sed -i -e "s|<install_directory>|/opt/yams|g" yams` the updated script worked fine. as this seems like a good opportunity I wanted to thank you for this very nice project. makes running a homeserver for your digitized media incredibly effortless. the upgrade tutorial is also great! very easy to follow
rogs commented 2024-12-23 12:34:32 -03:00 (Migrated from gitlab.com)
Copy Link

This was already fixed. Thanks!

This was already fixed. Thanks!
rogs (Migrated from gitlab.com) closed this issue 2024-12-23 12:34:32 -03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
add-to-docs
bug
done
feature-request
in progress
troubleshooting
v2
yams extra
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
rogs
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rogs/yams#33
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?