rogs/yams
rogs/yams
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

Suggested changes to the check-vpn option #23

New Issue
Closed
opened 2023-10-25 14:14:41 -03:00 by hhatcher · 3 comments
hhatcher commented 2023-10-25 14:14:41 -03:00 (Migrated from gitlab.com)
Copy Link

When running the check-vpn option, if the user is in a region or an ISP where ifconfig.me is unavailable, the script will fail. It was easy enough to fix by editing the yams script, but it might be good to make the IP address provider configurable (e.g. curl -s api.ipify.org worked for me).

Also, it might be worth altering the check-vpn option to check the local IP/country first, so there's more information if docker exec qbittorrent sh -c "curl -s ifconfig.me" doesn't succeed. (This will at least confirm that the YAMS instance has internet connectivity prior to testing components that are dependent on the VPN/gluetun configuration.)

When running the `check-vpn` option, if the user is in a region or an ISP where `ifconfig.me` is unavailable, the script will fail. It was easy enough to fix by editing the yams script, but it might be good to make the IP address provider configurable (e.g. `curl -s api.ipify.org` worked for me). Also, it might be worth altering the check-vpn option to check the local IP/country first, so there's more information if `docker exec qbittorrent sh -c "curl -s ifconfig.me"` doesn't succeed. (This will at least confirm that the YAMS instance has internet connectivity prior to testing components that are dependent on the VPN/gluetun configuration.)
rogs commented 2023-10-25 14:16:31 -03:00 (Migrated from gitlab.com)
Copy Link

Thank you for the bug report and excellent suggestions @hhatcher! I'll make the change later today, but also MRs are always accepted! If you have fixed it locally, feel free to open a new MR 😄

Thank you for the bug report and excellent suggestions @hhatcher! I'll make the change later today, but also MRs are always accepted! If you have fixed it locally, feel free to open a new MR :smile:
rogs commented 2023-10-25 14:41:45 -03:00 (Migrated from gitlab.com)
Copy Link

mentioned in merge request !12

mentioned in merge request !12
rogs commented 2023-10-25 14:45:45 -03:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 7f6d9e86bf

mentioned in commit 7f6d9e86bfd729267842e54f668b3bf241092837
rogs (Migrated from gitlab.com) closed this issue 2023-10-25 14:45:47 -03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
add-to-docs
bug
done
feature-request
in progress
troubleshooting
v2
yams extra
No Label
bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
rogs
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rogs/yams#23
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?