From 7a4d497353cc7cf62dcac3b23c154bf41a0752b6 Mon Sep 17 00:00:00 2001 From: Sebastian Spaeth Date: Tue, 12 Mar 2024 18:02:44 +0100 Subject: [PATCH] Optimize Sanity Check SQL Instead of SELECT COUNT(media_id) from mediaapi_thumbnail WHERE media_id NOT IN (SELECT media_id FROM mediaapi_media_repository); we do SELECT COUNT(media_id) from mediaapi_thumbnail WHERE NOT EXISTS (SELECT media_id FROM mediaapi_media_repository); Per Till's (@s7evink:matrix.org) suggestion. All credit to him --- cleanmedia | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cleanmedia b/cleanmedia index c74ab89..acba86e 100755 --- a/cleanmedia +++ b/cleanmedia @@ -177,7 +177,7 @@ class MediaRepository: def sanity_check_thumbnails(self) -> None: """Warn if we have thumbnails in the db that do not refer to existing media""" with self.conn.cursor() as cur: - cur.execute("SELECT COUNT(media_id) from mediaapi_thumbnail WHERE media_id NOT IN (SELECT media_id FROM mediaapi_media_repository);") + cur.execute("SELECT COUNT(media_id) from mediaapi_thumbnail WHERE NOT EXISTS (SELECT media_id FROM mediaapi_media_repository);") row = cur.fetchone() if row is not None and row[0]: logging.error("You have {} thumbnails in your db that do not refer to media. This needs fixing (we don't do that)!".format(row[0]))